Fix BoundedInt Sub libfunc #1465
Draft
+207
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
+ Coverage 81.69% 81.76% +0.06%
==========================================
Files 105 105
Lines 26047 26109 +62
==========================================
+ Hits 21279 21347 +68
+ Misses 4768 4762 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.954 ± 0.076 | 10.820 | 11.115 | 4.44 ± 0.07 |
cairo-native (embedded AOT) |
2.467 ± 0.034 | 2.402 | 2.510 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.538 ± 0.014 | 2.516 | 2.557 | 1.03 ± 0.02 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
528.4 ± 6.8 | 520.4 | 540.3 | 1.00 |
cairo-native (embedded AOT) |
2148.8 ± 21.1 | 2115.1 | 2181.3 | 4.07 ± 0.07 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2264.2 ± 34.4 | 2227.8 | 2340.9 | 4.28 ± 0.09 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.728 ± 0.019 | 4.713 | 4.772 | 1.83 ± 0.01 |
cairo-native (embedded AOT) |
2.579 ± 0.008 | 2.565 | 2.593 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.628 ± 0.023 | 2.606 | 2.678 | 1.02 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.695 ± 0.014 | 4.670 | 4.713 | 2.24 ± 0.01 |
cairo-native (embedded AOT) |
2.097 ± 0.008 | 2.080 | 2.109 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.145 ± 0.024 | 2.125 | 2.206 | 1.02 ± 0.01 |
Benchmark for program heavy_circuit
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
9.648 ± 0.077 | 9.476 | 9.769 | 1.00 |
cairo-native (embedded AOT) |
13.618 ± 0.072 | 13.491 | 13.712 | 1.41 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
13.888 ± 0.089 | 13.740 | 14.041 | 1.44 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
560.0 ± 3.8 | 553.7 | 565.6 | 1.00 |
cairo-native (embedded AOT) |
2198.8 ± 18.5 | 2168.4 | 2225.9 | 3.93 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2354.8 ± 54.8 | 2314.4 | 2474.6 | 4.20 ± 0.10 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
375.6 ± 2.6 | 372.7 | 381.9 | 1.00 |
cairo-native (embedded AOT) |
2264.6 ± 19.3 | 2245.0 | 2314.6 | 6.03 ± 0.07 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2443.3 ± 23.2 | 2420.6 | 2500.9 | 6.51 ± 0.08 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BoundedInt Sub libfunc
The previous implementation of the sub libfunc had some cases in which it failed to return the correct result. We decided to change the algorithm to one that is simpler to understand and is mathematically correct.
We have C = A - B, where all of them are
BoundedInt. We represent the aBoundedIntas:BoundedInt.BoundedIntrange.So we want to get
Cdand we haveCo + Cd = ( Ao + Ad ) - ( Bo + Bd )->Cd = Ao + Ad - Bo - Bd - Co.Closes #1449
Introduces Breaking Changes?
No.
Checklist